Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1663323003: [fullcode] Change fullcode to compile finally using the token approach. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/x64/full-codegen-x64.cc
diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc
index a5c3421223e84381f09bb77fbeca6e118ba17615..452fe10518ceea2bc7702580b518c868492a080a 100644
--- a/src/full-codegen/x64/full-codegen-x64.cc
+++ b/src/full-codegen/x64/full-codegen-x64.cc
@@ -16,8 +16,7 @@
namespace v8 {
namespace internal {
-#define __ ACCESS_MASM(masm_)
-
+#define __ ACCESS_MASM(masm())
class JumpPatchSite BASE_EMBEDDED {
public:
@@ -67,6 +66,7 @@ class JumpPatchSite BASE_EMBEDDED {
__ j(cc, target, near_jump);
}
+ MacroAssembler* masm() { return masm_; }
MacroAssembler* masm_;
Label patch_site_;
#ifdef DEBUG
@@ -1878,8 +1878,7 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
__ j(not_equal, &resume);
__ Push(result_register());
EmitCreateIteratorResult(true);
- EmitUnwindBeforeReturn();
- EmitReturnSequence();
+ EmitUnwindAndReturn();
__ bind(&suspend);
VisitForAccumulatorValue(expr->generator_object());
@@ -1910,8 +1909,7 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
case Yield::kFinal: {
// Pop value from top-of-stack slot, box result into result register.
EmitCreateIteratorResult(true);
- EmitUnwindBeforeReturn();
- EmitReturnSequence();
+ EmitUnwindAndReturn();
break;
}
@@ -4590,16 +4588,6 @@ void FullCodeGenerator::PushFunctionArgumentForContextAllocation() {
void FullCodeGenerator::EnterFinallyBlock() {
DCHECK(!result_register().is(rdx));
- DCHECK(!result_register().is(rcx));
- // Cook return address on top of stack (smi encoded Code* delta)
- __ PopReturnAddressTo(rdx);
- __ Move(rcx, masm_->CodeObject());
- __ subp(rdx, rcx);
- __ Integer32ToSmi(rdx, rdx);
- __ Push(rdx);
-
- // Store result register while executing finally block.
- __ Push(result_register());
// Store pending message while executing finally block.
ExternalReference pending_message_obj =
@@ -4613,22 +4601,11 @@ void FullCodeGenerator::EnterFinallyBlock() {
void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(rdx));
- DCHECK(!result_register().is(rcx));
// Restore pending message from stack.
__ Pop(rdx);
ExternalReference pending_message_obj =
ExternalReference::address_of_pending_message_obj(isolate());
__ Store(pending_message_obj, rdx);
-
- // Restore result register from stack.
- __ Pop(result_register());
-
- // Uncook return address.
- __ Pop(rdx);
- __ SmiToInteger32(rdx, rdx);
- __ Move(rcx, masm_->CodeObject());
- __ addp(rdx, rcx);
- __ jmp(rdx);
}
@@ -4646,6 +4623,31 @@ void FullCodeGenerator::EmitLoadStoreICSlot(FeedbackVectorSlot slot) {
__ Move(VectorStoreICTrampolineDescriptor::SlotRegister(), SmiFromSlot(slot));
}
+void FullCodeGenerator::DeferredCommands::EmitCommands() {
+ __ Pop(result_register()); // Restore the accumulator.
+ __ Pop(rdx); // Get the token.
+ for (DeferredCommand cmd : commands_) {
+ Label skip;
+ __ SmiCompare(rdx, Smi::FromInt(cmd.token));
+ __ j(not_equal, &skip);
+ switch (cmd.command) {
+ case kReturn:
+ codegen_->EmitUnwindAndReturn();
+ break;
+ case kThrow:
+ __ Push(result_register());
+ __ CallRuntime(Runtime::kReThrow);
+ break;
+ case kContinue:
+ codegen_->EmitContinue(cmd.target);
+ break;
+ case kBreak:
+ codegen_->EmitBreak(cmd.target);
+ break;
+ }
+ __ bind(&skip);
+ }
+}
#undef __
@@ -4726,7 +4728,6 @@ BackEdgeTable::BackEdgeState BackEdgeTable::GetBackEdgeState(
return OSR_AFTER_STACK_CHECK;
}
-
} // namespace internal
} // namespace v8
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698