Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 16633008: Diagnose unresolved constructors in platform libraries. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, blois, ngeoffray
Visibility:
Public.

Description

Diagnose unresolved constructors in platform libraries. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=25145

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 1 chunk +1 line, -7 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M dart/sdk/lib/html/dart2js/html_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/analyze_api_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M dart/tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
7 years, 6 months ago (2013-06-11 11:08:04 UTC) #1
Johnni Winther
lgtm
7 years, 6 months ago (2013-06-11 11:35:01 UTC) #2
ahe
Incorporating dart:html changes from 19754002 and submitting.
7 years, 5 months ago (2013-07-18 12:49:40 UTC) #3
ahe
7 years, 5 months ago (2013-07-18 12:50:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698