Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: src/stub-cache.cc

Issue 166323015: Remove ASSERT related to major-key, it's not given that they match. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 191
192 // Compile the stub that is either shared for all names or 192 // Compile the stub that is either shared for all names or
193 // name specific if there are global objects involved. 193 // name specific if there are global objects involved.
194 Handle<Code> handler = FindHandler( 194 Handle<Code> handler = FindHandler(
195 cache_name, stub_holder, Code::LOAD_IC, flag, Code::FAST); 195 cache_name, stub_holder, Code::LOAD_IC, flag, Code::FAST);
196 if (!handler.is_null()) { 196 if (!handler.is_null()) {
197 #ifdef DEBUG 197 #ifdef DEBUG
198 LoadStubCompiler compiler(isolate_, kNoExtraICState, flag); 198 LoadStubCompiler compiler(isolate_, kNoExtraICState, flag);
199 Handle<Code> compiled = compiler.CompileLoadNonexistent( 199 Handle<Code> compiled = compiler.CompileLoadNonexistent(
200 type, last, cache_name); 200 type, last, cache_name);
201 ASSERT(compiled->major_key() == handler->major_key());
202 ASSERT(compiled->flags() == handler->flags()); 201 ASSERT(compiled->flags() == handler->flags());
203 #endif 202 #endif
204 return handler; 203 return handler;
205 } 204 }
206 205
207 LoadStubCompiler compiler(isolate_, kNoExtraICState, flag); 206 LoadStubCompiler compiler(isolate_, kNoExtraICState, flag);
208 handler = compiler.CompileLoadNonexistent(type, last, cache_name); 207 handler = compiler.CompileLoadNonexistent(type, last, cache_name);
209 Map::UpdateCodeCache(stub_holder, cache_name, handler); 208 Map::UpdateCodeCache(stub_holder, cache_name, handler);
210 return handler; 209 return handler;
211 } 210 }
(...skipping 1257 matching lines...) Expand 10 before | Expand all | Expand 10 after
1469 Handle<FunctionTemplateInfo>( 1468 Handle<FunctionTemplateInfo>(
1470 FunctionTemplateInfo::cast(signature->receiver())); 1469 FunctionTemplateInfo::cast(signature->receiver()));
1471 } 1470 }
1472 } 1471 }
1473 1472
1474 is_simple_api_call_ = true; 1473 is_simple_api_call_ = true;
1475 } 1474 }
1476 1475
1477 1476
1478 } } // namespace v8::internal 1477 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698