Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 166323005: Remove reserved value check in IndependentAndDisposableSamples. (Closed)

Created:
6 years, 10 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove reserved value check in IndependentAndDisposableSamples. Earlier versions of ISO 14496-12 indicated that the upper 2 bits of the sample_info was reserved and must be 0. The current version of ISO 14496-12:2012 now allows these bits to be non-zero so we need to remove the check so the content will play. The new non-zero values are not needed by the current code so we don't need any extra logic. BUG=344737 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M media/formats/mp4/box_definitions.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 10 months ago (2014-02-19 02:10:48 UTC) #1
DaleCurtis
lgtm
6 years, 10 months ago (2014-02-19 02:12:31 UTC) #2
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 10 months ago (2014-02-19 02:14:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/166323005/1
6 years, 10 months ago (2014-02-19 02:17:26 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:04:43 UTC) #5
Message was sent while issue was closed.
Change committed as 251989

Powered by Google App Engine
This is Rietveld 408576698