Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Issue 16632009: Set AllowOverlappingViews for history overlay (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
index 17dac1bc613953e2cb4025c1aaf4e1b70011a141..1795fc06b2f0ab951150f5c167b81a5902eba023 100644
--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
@@ -179,6 +179,10 @@ class SpellCheckRenderViewObserver : public content::RenderViewHostObserver {
((shouldGoBack && canGoBack && !isRightScroll) ||
(shouldGoForward && canGoForward && isRightScroll))) {
+ BrowserWindowController* windowController =
+ [BrowserWindowController browserWindowControllerForView:
+ renderWidgetHost_->GetView()->GetNativeView()];
+
// Released by the tracking handler once the gesture is complete.
HistoryOverlayController* historyOverlay =
[[HistoryOverlayController alloc]
@@ -218,6 +222,7 @@ class SpellCheckRenderViewObserver : public content::RenderViewHostObserver {
if (phase == NSEventPhaseBegan) {
[historyOverlay showPanelForView:
renderWidgetHost_->GetView()->GetNativeView()];
+ [windowController onHistoryOverlayShown];
return;
}
@@ -239,8 +244,10 @@ class SpellCheckRenderViewObserver : public content::RenderViewHostObserver {
chrome::GoBack(browser, CURRENT_TAB);
}
- if (isComplete)
+ if (isComplete) {
[historyOverlay release];
+ [windowController onHistoryOverlayHidden];
+ }
}];
return YES;
}

Powered by Google App Engine
This is Rietveld 408576698