Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1663163003: Initial split of precompilation code from compiler.cc (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initial split of precompilation code from compiler.cc This removes precompiler code from the regular JIT-mode VM, and allows us to add more precompilation-specific optimizations without affecting the JIT compiler. Remove JIT-related code from precompiler pipeline: No type feedback, no OSR, no deopt, no block reordering, no background compilation With precompilation, use precompiler pipeline for static initializers and const expressions as well. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/117c7b0d3eee57e13b7260f4b35dd771d047ee8e

Patch Set 1 #

Total comments: 5

Patch Set 2 : addressed comments #

Patch Set 3 : fixed Linux linker error, moved disassemble code #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1193 lines, -355 lines) Patch
M runtime/vm/compiler.h View 1 2 3 4 chunks +50 lines, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 23 chunks +128 lines, -346 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/disassembler.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 2 3 chunks +145 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.h View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 3 6 chunks +849 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Florian Schneider
This only deals with compiler.cc. flow_graph_optimizer.cc will be next.
4 years, 10 months ago (2016-02-03 22:09:55 UTC) #2
rmacnak
dart_precompiled_runtime doesn't link for me. https://codereview.chromium.org/1663163003/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1663163003/diff/1/runtime/vm/compiler.cc#newcode589 runtime/vm/compiler.cc:589: volatile bool use_speculative_inlining = ...
4 years, 10 months ago (2016-02-04 00:36:39 UTC) #3
Florian Schneider
Hm, I can't reproduce the linker error on my Mac/Linux machines. https://codereview.chromium.org/1663163003/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): ...
4 years, 10 months ago (2016-02-05 01:55:52 UTC) #4
rmacnak
lgtm Builds for me after your latest change https://codereview.chromium.org/1663163003/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1663163003/diff/1/runtime/vm/precompiler.cc#newcode1748 runtime/vm/precompiler.cc:1748: "SelectRepresentations"); ...
4 years, 10 months ago (2016-02-08 22:43:23 UTC) #5
Florian Schneider
4 years, 10 months ago (2016-02-09 10:29:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
117c7b0d3eee57e13b7260f4b35dd771d047ee8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698