Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1663093002: Revert of Add gpu implementation of SkAvoidXfermode (Closed)

Created:
4 years, 10 months ago by mtklein
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add gpu implementation of SkAvoidXfermode (patchset #10 id:170001 of https://codereview.chromium.org/1658623002/ ) Reason for revert: shader compilation failures error C1008: undefined variable "null" https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/4064/steps/dm/logs/stdio Original issue's description: > Add gpu implementation of SkAvoidXfermode > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658623002 > > TBR=bsalomon@google.com > > Committed: https://skia.googlesource.com/skia/+/15691a055db9b68c9b48f589e48d8a85888cf83f TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f16e2a2e92df1eabd04e9e1260ef0b763ecfa426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -459 lines) Patch
M gm/avoidxfermode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D gm/avoidxfermode2.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
M include/client/android/SkAvoidXfermode.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 1 chunk +1 line, -363 lines 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Add gpu implementation of SkAvoidXfermode
4 years, 10 months ago (2016-02-03 14:42:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663093002/1
4 years, 10 months ago (2016-02-03 14:42:10 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 14:42:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f16e2a2e92df1eabd04e9e1260ef0b763ecfa426

Powered by Google App Engine
This is Rietveld 408576698