src/DartARM32/assembler_arm.h - Issue 1663053008: Fix vector load/stores in the ARM assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1663053008: Fix vector load/stores in the ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits and revert python file. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/DartARM32/assembler_arm.h

diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h

index 84f9187a4801cb659e678ba4d3043ea606f900a7..80cf22f91e425e01cd9c6ec3f6be9ca209c68550 100644

--- a/src/DartARM32/assembler_arm.h

+++ b/src/DartARM32/assembler_arm.h

@@ -1405,8 +1405,10 @@ class Assembler : public ValueObject {

// ARM32::AssemblerARM32::uxt() (uxtb and uxth).

// ARM32::AssemblerARM32::vpop()

// ARM32::AssemblerARM32::vpush()

- // ARM32::AssemblerARM:rbit().

- // ARM32::AssemblerARM::veord()

+ // ARM32::AssemblerARM32:rbit().

Jim Stichnoth 2016/02/04 20:47:36 remove the period here and above

Karl 2016/02/04 21:55:22 Done.

+ // ARM32::AssemblerARM32::veord()

+ // ARM32::AssemblerARM32::vld1qr()

+ // ARM32::AssemblerARM32::vst1qr()

#endif

DISALLOW_ALLOCATION();

« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | no next file with comments »