Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1663053006: perf: Add a power benchmark for pages with heavy ads (Closed)

Created:
4 years, 10 months ago by Sami
Modified:
4 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, charliea (OOO until 10-5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Add a power benchmark for pages with heavy ads BUG=487937 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/21b10a9cbdf2b2bd4f8589793aeee112d962821e Cr-Commit-Position: refs/heads/master@{#374812}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo. #

Patch Set 3 : Unbreak cnn URL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -40 lines) Patch
M tools/perf/benchmarks/power.py View 1 chunk +14 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_ad_cases.py View 1 2 6 chunks +53 lines, -38 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
Sami
4 years, 10 months ago (2016-02-04 16:02:33 UTC) #4
sullivan
+charliea who is looking at test scenarios for power
4 years, 10 months ago (2016-02-04 16:04:19 UTC) #6
alex clarke (OOO till 29th)
https://codereview.chromium.org/1663053006/diff/1/tools/perf/page_sets/tough_ad_cases.py File tools/perf/page_sets/tough_ad_cases.py (right): https://codereview.chromium.org/1663053006/diff/1/tools/perf/page_sets/tough_ad_cases.py#newcode225 tools/perf/page_sets/tough_ad_cases.py:225: class ScrollingToughAdCasesPageSet(story.StorySet): Is this inheritance right?
4 years, 10 months ago (2016-02-04 16:29:06 UTC) #7
Sami
https://codereview.chromium.org/1663053006/diff/1/tools/perf/page_sets/tough_ad_cases.py File tools/perf/page_sets/tough_ad_cases.py (right): https://codereview.chromium.org/1663053006/diff/1/tools/perf/page_sets/tough_ad_cases.py#newcode225 tools/perf/page_sets/tough_ad_cases.py:225: class ScrollingToughAdCasesPageSet(story.StorySet): On 2016/02/04 16:29:06, alexclarke1 wrote: > Is ...
4 years, 10 months ago (2016-02-04 16:30:16 UTC) #8
alex clarke (OOO till 29th)
lgtm
4 years, 10 months ago (2016-02-04 16:32:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663053006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663053006/20001
4 years, 10 months ago (2016-02-04 16:40:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176343)
4 years, 10 months ago (2016-02-04 17:26:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663053006/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663053006/30001
4 years, 10 months ago (2016-02-04 18:49:34 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3288)
4 years, 10 months ago (2016-02-05 03:18:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663053006/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663053006/30001
4 years, 10 months ago (2016-02-05 13:57:26 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-06 01:12:41 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663053006/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663053006/30001
4 years, 10 months ago (2016-02-10 13:37:08 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 10 months ago (2016-02-11 00:57:04 UTC) #26
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:27 UTC) #28
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/21b10a9cbdf2b2bd4f8589793aeee112d962821e
Cr-Commit-Position: refs/heads/master@{#374812}

Powered by Google App Engine
This is Rietveld 408576698