Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1663013002: Reland of [heap] Simplify distribution of remaining memory during sweeping & compaction (Closed)

Created:
4 years, 10 months ago by Michael Hablich
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Simplify distribution of remaining memory during sweeping & compaction (patchset #1 id:1 of https://codereview.chromium.org/1661723003/ ) Reason for revert: Bisection results show that this was not the culprit. Original issue's description: > Revert of [heap] Simplify distribution of remaining memory during sweeping & compaction (patchset #2 id:80001 of https://codereview.chromium.org/1653973003/ ) > > Reason for revert: > Very likely blocking roll: https://codereview.chromium.org/1652413003/ > > Original issue's description: > > [heap] Simplify distribution of remaining memory during sweeping & compaction > > > > BUG=chromium:524425 > > LOG=N > > > > Committed: https://crrev.com/f72923526ccaa8faef5c977267b0c074c4a44dfa > > Cr-Commit-Position: refs/heads/master@{#33668} > > TBR=hpayer@chromium.org,mlippautz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:524425 > > Committed: https://crrev.com/a9441b0e7a2a56c2047482a3cc66e3ca2255444b > Cr-Commit-Position: refs/heads/master@{#33695} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/86dd673c2c52884748c120b593d8d1c729fa3268 Cr-Commit-Position: refs/heads/master@{#33696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -316 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M test/cctest/heap/heap-tester.h View 1 chunk +0 lines, -19 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +0 lines, -230 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Reland of [heap] Simplify distribution of remaining memory during sweeping & compaction
4 years, 10 months ago (2016-02-03 09:43:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663013002/1
4 years, 10 months ago (2016-02-03 09:43:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 09:44:09 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 09:44:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86dd673c2c52884748c120b593d8d1c729fa3268
Cr-Commit-Position: refs/heads/master@{#33696}

Powered by Google App Engine
This is Rietveld 408576698