[Release] Automatically notify mailing list on a pending merge

tools/release/test_scripts.py

Index: tools/release/test_scripts.py
diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py
index 07f5c40c3bdd61e72bd4cd92bd91b8f7373aa588..df8363a62b8d247f0de8160355b7867d75095ada 100644
--- a/tools/release/test_scripts.py
+++ b/tools/release/test_scripts.py
@@ -389,6 +389,18 @@ class ScriptTest(unittest.TestCase):
       f.write("  // Some line...\n")
       f.write("#define V8_IS_CANDIDATE_VERSION 0\n")
 
+  def WriteFakeWatchlistsFile(self):
+    watchlists_file = os.path.join(TEST_CONFIG["DEFAULT_CWD"], WATCHLISTS_FILE)
+    if not os.path.exists(os.path.dirname(watchlists_file)):
+      os.makedirs(os.path.dirname(watchlists_file))
+    with open(watchlists_file, "w") as f:
+      f.write("  // Some line...\n")
+      f.write("\n")
+      f.write("'merges': [")
+      f.write("# Only enabled on branches created with tools/release/create_release.py")
+      f.write("# 'v8-merges@googlegroups.com',")

[Michael Achenbach, 2016/02/04 08:19:41]

Please add the same whitespace as in the original file and make sure the regexps
still apply. You'd also need '\n' in the end of each line. Generally I find
multi-line strings in python more readable with """-strings (optionally with
local var):

  f.write("""
  'merges': [
    # Only enabled on branches created with tools/release/create_release.py
    # 'v8-merges@googlegroups.com',
  ],""")

[Michael Hablich, 2016/02/04 09:01:22]

Ack and done. Just copied the style in the method above.

+      f.write("],")
+
   def MakeStep(self):
     """Convenience wrapper."""
     options = ScriptsBase(TEST_CONFIG, self, self._state).MakeOptions([])
@@ -952,6 +964,8 @@ Performance and stability improvements on all platforms."""
       Cmd("git checkout -f 3.22.4 -- ChangeLog", "", cb=ResetChangeLog),
       Cmd("git checkout -f 3.22.4 -- include/v8-version.h", "",
           cb=self.WriteFakeVersionFile),
+      Cmd("git checkout -f 3.22.4 -- WATCHLISTS", "",
+          cb=self.WriteFakeWatchlistsFile),
       Cmd("git commit -aF \"%s\"" % TEST_CONFIG["COMMITMSG_FILE"], "",
           cb=CheckVersionCommit),
       Cmd("git push origin "