Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1662993002: WIP: add totally reproducible git cl upload hooks. (Closed)

Created:
4 years, 10 months ago by tandrii(chromium)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WIP: add totally reproducible git cl upload hooks. BUG=

Patch Set 1 #

Patch Set 2 : More. #

Patch Set 3 : git config email/name #

Patch Set 4 : move #

Patch Set 5 : fix trigger #

Patch Set 6 : fix cwd #

Patch Set 7 : fix cwd #

Patch Set 8 : more #

Patch Set 9 : more #

Patch Set 10 : new try recipe #

Patch Set 11 : correct builder names #

Patch Set 12 : PS1 #

Patch Set 13 : fix z.sh #

Patch Set 14 : new #

Patch Set 15 : Test #

Patch Set 16 : test #

Patch Set 17 : test #

Patch Set 18 : with path #

Patch Set 19 : version #

Patch Set 20 : verbose #

Patch Set 21 : issue 589201 #

Patch Set 22 : Workaround #

Patch Set 23 : ok, that should work now #

Patch Set 24 : conditional remove #

Patch Set 25 : detect user #

Patch Set 26 : detect user(fix) #

Patch Set 27 : hooks not existing fix #

Patch Set 28 : ps10 #

Patch Set 29 : More. #

Patch Set 30 : bring back windows #

Patch Set 31 : expecations + always delete repo. #

Patch Set 32 : +path depot_tools #

Total comments: 3

Patch Set 33 : win sucks #

Patch Set 34 : bp #

Patch Set 35 : windows, please work! #

Patch Set 36 : bootstrap git #

Patch Set 37 : argh #

Patch Set 38 : improved z.sh #

Patch Set 39 : improved z.sh #

Patch Set 40 : simply to test windows #

Patch Set 41 : win flake #

Patch Set 42 : rebases #

Patch Set 43 : win+todo #

Patch Set 44 : fix #

Patch Set 45 : try subprocess #

Patch Set 46 : test #

Patch Set 47 : a #

Patch Set 48 : sane. #

Patch Set 49 : u #

Patch Set 50 : uu #

Patch Set 51 : u #

Patch Set 52 : u #

Patch Set 53 : U #

Patch Set 54 : u #

Patch Set 55 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+914 lines, -0 lines) Patch
A scripts/slave/recipes/infra/git_cl.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 1 chunk +176 lines, -0 lines 0 comments Download
A scripts/slave/recipes/infra/git_cl.expected/insane.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +367 lines, -0 lines 0 comments Download
A scripts/slave/recipes/infra/git_cl.expected/sane.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +355 lines, -0 lines 0 comments Download
A scripts/slave/recipes/z.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
martiniss
https://codereview.chromium.org/1662993002/diff/620001/scripts/slave/recipes/infra/git_cl.py File scripts/slave/recipes/infra/git_cl.py (right): https://codereview.chromium.org/1662993002/diff/620001/scripts/slave/recipes/infra/git_cl.py#newcode4 scripts/slave/recipes/infra/git_cl.py:4: """A continious builder for build repo which simulates recipes.""" ...
4 years, 9 months ago (2016-02-29 22:35:14 UTC) #1
tandrii(chromium)
yay thanks for review. https://codereview.chromium.org/1662993002/diff/620001/scripts/slave/recipes/infra/git_cl.py File scripts/slave/recipes/infra/git_cl.py (right): https://codereview.chromium.org/1662993002/diff/620001/scripts/slave/recipes/infra/git_cl.py#newcode94 scripts/slave/recipes/infra/git_cl.py:94: ok_ret='any', name='delete old feature branch') ...
4 years, 9 months ago (2016-03-01 09:48:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662993002/720001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662993002/720001
4 years, 9 months ago (2016-03-02 15:09:01 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 15:16:32 UTC) #6
Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

Powered by Google App Engine
This is Rietveld 408576698