Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: src/interpreter/source-position-table.cc

Issue 1662983002: [interpreter] add source positions for call and call-new. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test expectations Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/source-position-table.h ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/source-position-table.cc
diff --git a/src/interpreter/source-position-table.cc b/src/interpreter/source-position-table.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f408f159db3bef2df859043eab3b41cd7c0da6b6
--- /dev/null
+++ b/src/interpreter/source-position-table.cc
@@ -0,0 +1,81 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/interpreter/source-position-table.h"
+
+#include "src/assembler.h"
+#include "src/objects-inl.h"
+#include "src/objects.h"
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+class IsStatementField : public BitField<bool, 0, 1> {};
+class SourcePositionField : public BitField<int, 1, 30> {};
+
+void SourcePositionTableBuilder::AddStatementPosition(int bytecode_offset,
+ int source_position) {
+ AssertMonotonic(bytecode_offset);
+ uint32_t encoded = IsStatementField::encode(true) |
+ SourcePositionField::encode(source_position);
+ entries_.push_back({bytecode_offset, encoded});
+}
+
+void SourcePositionTableBuilder::AddExpressionPosition(int bytecode_offset,
+ int source_position) {
+ AssertMonotonic(bytecode_offset);
+ uint32_t encoded = IsStatementField::encode(false) |
+ SourcePositionField::encode(source_position);
+ entries_.push_back({bytecode_offset, encoded});
+}
+
+Handle<FixedArray> SourcePositionTableBuilder::ToFixedArray() {
+ int length = static_cast<int>(entries_.size());
+ Handle<FixedArray> table =
+ isolate_->factory()->NewFixedArray(length * 2, TENURED);
+ for (int i = 0; i < length; i++) {
+ table->set(i * 2, Smi::FromInt(entries_[i].bytecode_offset));
+ table->set(i * 2 + 1, Smi::FromInt(entries_[i].source_position_and_type));
+ }
+ return table;
+}
+
+SourcePositionTableIterator::SourcePositionTableIterator(
+ BytecodeArray* bytecode_array)
+ : table_(bytecode_array->source_position_table()),
+ index_(0),
+ length_(table_->length()) {
+ DCHECK(table_->length() % 2 == 0);
+ Advance();
+}
+
+void SourcePositionTableIterator::Advance() {
+ if (index_ < length_) {
+ int new_bytecode_offset = Smi::cast(table_->get(index_))->value();
+ // Bytecode offsets are in ascending order.
+ DCHECK(bytecode_offset_ < new_bytecode_offset || index_ == 0);
+ bytecode_offset_ = new_bytecode_offset;
+ uint32_t source_position_and_type =
+ static_cast<uint32_t>(Smi::cast(table_->get(index_ + 1))->value());
+ is_statement_ = IsStatementField::decode(source_position_and_type);
+ source_position_ = SourcePositionField::decode(source_position_and_type);
+ }
+ index_ += 2;
+}
+
+int SourcePositionTableIterator::PositionFromBytecodeOffset(
+ BytecodeArray* bytecode_array, int bytecode_offset) {
+ int last_position = 0;
+ for (SourcePositionTableIterator iterator(bytecode_array);
+ !iterator.done() && iterator.bytecode_offset() <= bytecode_offset;
+ iterator.Advance()) {
+ last_position = iterator.source_position();
+ }
+ return last_position;
+}
+
+} // namespace interpreter
+} // namespace internal
+} // namespace v8
« no previous file with comments | « src/interpreter/source-position-table.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698