Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1662953002: [runtime] Remove unused prefix_argc from GetCallerArguments. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove unused prefix_argc from GetCallerArguments. We always call GetCallerArguments with 0 for prefix_argc, and so there's no use in having that parameter at all. R=yangguo@chromium.org Committed: https://crrev.com/8ecbc2c5d694a32be6af772636b2a6b1cac8073e Cr-Commit-Position: refs/heads/master@{#33694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M src/runtime/runtime-scopes.cc View 8 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-03 05:46:15 UTC) #1
Benedikt Meurer
Hey Yang, Simple cleanup to GetCallerArguments. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-03 05:46:44 UTC) #2
Yang
On 2016/02/03 05:46:15, Benedikt Meurer wrote: interesting. lgtm.
4 years, 10 months ago (2016-02-03 05:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662953002/1
4 years, 10 months ago (2016-02-03 05:48:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 06:21:57 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 06:22:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ecbc2c5d694a32be6af772636b2a6b1cac8073e
Cr-Commit-Position: refs/heads/master@{#33694}

Powered by Google App Engine
This is Rietveld 408576698