Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1662913002: Initialize AltSvc flags to false in SpdySessionDependencies. (Closed)

Created:
4 years, 10 months ago by Bence
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize AltSvc flags to false in SpdySessionDependencies. |parse_alternative_services| and |enable_alternative_service_with_different_host| are experimental features, they should be disabled by default, even in a test helper class. In both constructors. Committed: https://crrev.com/0cdf68a4de725b63030df1914d9fd615b7c12bcb Cr-Commit-Position: refs/heads/master@{#373240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/spdy/spdy_test_util_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 10 months ago (2016-02-03 14:20:33 UTC) #2
Ryan Hamilton
lgtm
4 years, 10 months ago (2016-02-03 14:40:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662913002/1
4 years, 10 months ago (2016-02-03 15:37:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 15:43:05 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 15:44:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cdf68a4de725b63030df1914d9fd615b7c12bcb
Cr-Commit-Position: refs/heads/master@{#373240}

Powered by Google App Engine
This is Rietveld 408576698