ios/chrome/browser/memory/memory_debugger_manager.mm - Issue 1662843002: Revert of Delete base/prefs and update callers to use components.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/memory/memory_debugger_manager.mm

Issue 1662843002: Revert of Delete base/prefs and update callers to use components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ios_chrome_main_parts.mm ('k') | ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/chrome/browser/memory/memory_debugger_manager.h"	5 #import "ios/chrome/browser/memory/memory_debugger_manager.h"

6	6

7 #include "base/ios/weak_nsobject.h"	7 #include "base/ios/weak_nsobject.h"

8 #import "base/mac/bind_objc_block.h"	8 #import "base/mac/bind_objc_block.h"

9 #include "base/mac/scoped_nsobject.h"	9 #include "base/mac/scoped_nsobject.h"

10 #include "components/prefs/pref_member.h"	10 #include "base/prefs/pref_member.h"

11 #include "components/prefs/pref_registry_simple.h"	11 #include "base/prefs/pref_registry_simple.h"

12 #include "components/prefs/pref_service.h"	12 #include "base/prefs/pref_service.h"

13 #import "ios/chrome/browser/memory/memory_debugger.h"	13 #import "ios/chrome/browser/memory/memory_debugger.h"

14 #import "ios/chrome/browser/pref_names.h"	14 #import "ios/chrome/browser/pref_names.h"

15	15

16 @implementation MemoryDebuggerManager {	16 @implementation MemoryDebuggerManager {

17 UIView* debuggerParentView_; // weak	17 UIView* debuggerParentView_; // weak

18 base::scoped_nsobject<MemoryDebugger> memoryDebugger_;	18 base::scoped_nsobject<MemoryDebugger> memoryDebugger_;

19 BooleanPrefMember showMemoryDebugger_;	19 BooleanPrefMember showMemoryDebugger_;

20 }	20 }

21	21

22 - (instancetype)initWithView:(UIView*)debuggerParentView	22 - (instancetype)initWithView:(UIView*)debuggerParentView

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 }	63 }

64 }	64 }

65	65

66 // Tears down the debugger so it can be deallocated.	66 // Tears down the debugger so it can be deallocated.

67 - (void)tearDownDebugger {	67 - (void)tearDownDebugger {

68 [memoryDebugger_ invalidateTimers];	68 [memoryDebugger_ invalidateTimers];

69 [memoryDebugger_ removeFromSuperview];	69 [memoryDebugger_ removeFromSuperview];

70 memoryDebugger_.reset();	70 memoryDebugger_.reset();

71 }	71 }

72 @end	72 @end

OLD	NEW