Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/report/templates.py

Issue 1662833005: Fixes Caterpillar crashing while generating report. (Closed) Base URL: https://github.com/chromium/caterpillar.git@master
Patch Set: Changed setUp to only run once for all end-to-end tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/end_to_end_test.py ('K') | « src/report/report.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/report/templates.py
diff --git a/src/report/templates.py b/src/report/templates.py
index 1fc2dd56b18f4d9a27b297370dffb34d905e64b8..d74c16e732f2a236a1c182ff855582b307383daa 100644
--- a/src/report/templates.py
+++ b/src/report/templates.py
@@ -175,7 +175,7 @@ TEMPLATE_FULL = jinja2.Template("""
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Caterpillar Conversion Report: {{ ca_manifest.name }}</title>
+ <title>Caterpillar Conversion Report: {{ chrome_app_manifest.name }}</title>
<link rel="stylesheet" href="report.css">
<body>
<div id="report">
diff --git "a/tests/test_app_minimal/my f\303\263lder \360\237\223\202/my f\303\255le" "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/bower_components/Inconsolata/This folder intentionally left blank"
similarity index 100%
copy from "tests/test_app_minimal/my f\303\263lder \360\237\223\202/my f\303\255le"
copy to "tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/bower_components/Inconsolata/This folder intentionally left blank"
diff --git "a/tests/test_app_minimal/my f\303\263lder \360\237\223\202/my f\303\255le" "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/bower_components/code-prettify/This folder intentionally left blank"
similarity index 100%
copy from "tests/test_app_minimal/my f\303\263lder \360\237\223\202/my f\303\255le"
copy to "tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/bower_components/code-prettify/This folder intentionally left blank"
diff --git "a/tests/test_app_minimal/my f\303\263lder \360\237\223\202/my f\303\255le" "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/bower_components/lato/This folder intentionally left blank"
similarity index 100%
copy from "tests/test_app_minimal/my f\303\263lder \360\237\223\202/my f\303\255le"
copy to "tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/bower_components/lato/This folder intentionally left blank"
diff --git "a/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/report.css" "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/report.css"
new file mode 100644
index 0000000000000000000000000000000000000000..2a924f1d6a8bc930c5296bdb2d5c2d3e39b04a1c
--- /dev/null
+++ "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/report.css"
@@ -0,0 +1 @@
+/* This file intentionally left blank. */
diff --git "a/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/report.html" "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/report.html"
new file mode 100644
index 0000000000000000000000000000000000000000..7b278fcc816958d1f34dfdcc2ca25db0dff5b3b1
--- /dev/null
+++ "b/tests/test_app_tts_output/report \342\234\223\342\234\223\342\234\223/report.html"
@@ -0,0 +1,190 @@
+
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="utf-8">
+ <title>Caterpillar Conversion Report: Text-to-Speech Chrome App</title>
+ <link rel="stylesheet" href="report.css">
+ <body>
+ <div id="report">
+ <h1>
+ Caterpillar Conversion Report:
+ <span class="name">Text-to-Speech Chrome App</span>
+ </h1>
+
+<section id="summary">
+ <h2>Summary</h2>
+ <span class="name">Text-to-Speech Chrome App</span> was
+ <span class="conversion-status total">
+
+ successfully
+
+ converted, with warnings.
+ </span>
+
+ <ul>
+
+ <li>
+ <span class="ca-feature none">
+ chrome.app.runtime
+ </span>
+ was not polyfilled.
+ </li>
+
+ <li>
+ <span class="ca-feature none">
+ chrome.app.window
+ </span>
+ was not polyfilled.
+ </li>
+
+ <li>
+ <span class="ca-feature total">
+ chrome.tts
+ </span>
+ was polyfilled.
+ </li>
+
+ </ul>
+</section>
+
+
+<section id="general-warnings">
+ <h2>General Warnings</h2>
+ <ul>
+
+ <li>Could not polyfill Chrome APIs: app.runtime, app.window</li>
+
+ <li>Manifest member `permissions` will not be converted.</li>
+
+ </ul>
+</section>
+
+
+
+<section id="polyfilled">
+ <h2>Polyfilled Chrome Apps APIs</h2>
+ <p>
+ Some Chrome Apps APIs have been polyfilled. Calls to these APIs will
+ generally still work, though there may be missing functionality. You should
+ check that the functionality you rely on still works.
+ </p>
+
+
+ <section class="polyfill">
+ <h3 class="ca-feature total">
+ chrome.tts
+ </h3>
+ <p>
+ <span class="ca-feature total">
+ chrome.tts
+ </span> was
+
+ polyfilled.
+ </p>
+
+ <p>
+ <span class="name">Text-to-Speech Chrome App</span> seems to make
+ use of features with missing or altered functionality in the polyfill:
+ </p>
+ <ul>
+
+ <li><span class="ca-feature total">chrome.tts.speak</span>: No longer supports extension ID.</li>
+
+ <li><span class="ca-feature total">chrome.tts.speak</span>: No longer supports gender.</li>
+
+ <li><span class="ca-feature total">chrome.tts.speak</span>: No longer supports required event types.</li>
+
+ </ul>
+
+
+ <p>
+ <span class="name">Text-to-Speech Chrome App</span> uses
+ <span class="ca-feature total">
+ tts
+ </span>
+ in the following places:
+ </p>
+
+ <p class="code-location path">𝓼𝓬𝓻𝓲𝓹𝓽𝓼/ttstest.js:5</p>
+<pre>
+<code class="prettyprint lang-js linenums:3">while (true)
+// TODO(Caterpillar): Check usage of tts.speak.
+ <span class="ca-feature total">chrome.tts.speak</span>('πŸ“’ chrome apps! πŸ“’');
+// end chrome app
+</code>
+</pre>
+
+ </section>
+
+</section>
+
+
+
+<section id="not-polyfilled">
+ <h2>Missing Chrome Apps APIs</h2>
+ <p>
+ Some Chrome Apps APIs have not been polyfilled, and your application may
+ rely on them. Places they are used in your application are shown below.
+ </p>
+
+
+ <section class="missing-api">
+ <h3 class="ca-feature none">
+ chrome.app.runtime
+ </h3>
+ <p>
+ <span class="name">Text-to-Speech Chrome App</span> uses
+ <span class="ca-feature none">
+ app.runtime
+ </span>
+ in the following places:
+ </p>
+
+ <p class="code-location path">𝓼𝓬𝓻𝓲𝓹𝓽𝓼/main.js:4</p>
+<pre>
+<code class="prettyprint lang-js linenums:2">// make a chrome app window
+// TODO(Caterpillar): Check usage of app.runtime.onLaunched.addListener.
+<span class="ca-feature none">chrome.app.runtime.onLaunched.addListener</span>(function() {
+// TODO(Caterpillar): Check usage of app.window.create.
+ chrome.app.window.create('ttstest.html', {
+</code>
+</pre>
+
+ </section>
+
+ <section class="missing-api">
+ <h3 class="ca-feature none">
+ chrome.app.window
+ </h3>
+ <p>
+ <span class="name">Text-to-Speech Chrome App</span> uses
+ <span class="ca-feature none">
+ app.window
+ </span>
+ in the following places:
+ </p>
+
+ <p class="code-location path">𝓼𝓬𝓻𝓲𝓹𝓽𝓼/main.js:6</p>
+<pre>
+<code class="prettyprint lang-js linenums:4">chrome.app.runtime.onLaunched.addListener(function() {
+// TODO(Caterpillar): Check usage of app.window.create.
+ <span class="ca-feature none">chrome.app.window.create</span>('ttstest.html', {
+ id: 'id'
+ });
+</code>
+</pre>
+
+ </section>
+
+</section>
+
+ </div>
+ <footer>
+ Generated by
+ <a href="https://github.com/chromium/caterpillar">Caterpillar</a>.
+ </footer>
+ <script src="bower_components/code-prettify/src/run_prettify.js">
+ </script>
+ </body>
+</html>
« src/end_to_end_test.py ('K') | « src/report/report.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698