src/caterpillar.py - Issue 1662833005: Fixes Caterpillar crashing while generating report.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/caterpillar.py

Issue 1662833005: Fixes Caterpillar crashing while generating report. (Closed) Base URL: https://github.com/chromium/caterpillar.git@master

Patch Set: Response to CR Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/caterpillar.py

diff --git a/src/caterpillar.py b/src/caterpillar.py

index 1d6f54cc3e08dab614b38a52ee4b9e532a074c97..ee92a2f6316b437ec81e16d41c4611c8ac7ab9fd 100755

--- a/src/caterpillar.py

+++ b/src/caterpillar.py

@@ -755,7 +755,8 @@ def convert_app(input_dir, output_dir, config, captured_warnings, force=False):

# Finally, generate and write a conversion report.

abs_report_dir = os.path.join(output_dir, report_dir)

report.generate_and_write(abs_report_dir, chrome_app_manifest,

- polyfill_manifests, status, captured_warnings, output_dir)

+ polyfill_manifests, status, captured_warnings, output_dir,

+ boilerplate_dir)

logging.info('Done.')

« no previous file with comments | « no previous file | src/end_to_end_test.py » ('j') | src/end_to_end_test.py » ('J')