Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: src/report/report.py

Issue 1662833005: Fixes Caterpillar crashing while generating report. (Closed) Base URL: https://github.com/chromium/caterpillar.git@master
Patch Set: Skipped broken test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/end_to_end_test.py ('k') | src/report/templates.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/report/report.py
diff --git a/src/report/report.py b/src/report/report.py
index a097d0eccec740c6613e529cd0551755286202fe..ba7cb8313590afb94b79dab4f18b7f7feacc525b 100644
--- a/src/report/report.py
+++ b/src/report/report.py
@@ -367,7 +367,7 @@ def install_bower_dependencies(dependencies, directory):
def generate_and_write(report_dir, chrome_app_manifest, apis, status, warnings,
- pwa_path):
+ web_path, boilerplate_dir):
"""Generates a conversion report and writes it to a directory.
Args:
@@ -377,9 +377,10 @@ def generate_and_write(report_dir, chrome_app_manifest, apis, status, warnings,
dictionaries.
status: Status representing conversion status of the entire app.
warnings: List of general warnings logged during conversion.
- pwa_path: Path to output progressive web app.
+ web_path: Path to output progressive web app.
"""
- report = generate(chrome_app_manifest, apis, status, warnings, pwa_path)
+ report = generate(chrome_app_manifest, apis, status, warnings, web_path,
+ boilerplate_dir)
report_path = os.path.join(report_dir, 'report.html')
with open(report_path, 'w') as report_file:
logging.info('Writing conversion report to `%s`.', report_path)
« no previous file with comments | « src/end_to_end_test.py ('k') | src/report/templates.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698