Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/end_to_end_test.py

Issue 1662833005: Fixes Caterpillar crashing while generating report. (Closed) Base URL: https://github.com/chromium/caterpillar.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/caterpillar.py ('k') | src/report/report.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/end_to_end_test.py
diff --git a/src/end_to_end_test.py b/src/end_to_end_test.py
index 8c3582154c9e9bb3cc253fe54c07e95a1a37b6bd..df6d0bfd0144e0f069b514bb37e5e001b6dc9e48 100644
--- a/src/end_to_end_test.py
+++ b/src/end_to_end_test.py
@@ -81,12 +81,18 @@ class TestEndToEndConvert(caterpillar_test.TestCaseWithTempDir):
"""Tests that the output matches the reference output."""
expected_files = set()
for dirname, _, filenames in os.walk(TTS_REFERENCE_PATH):
Matt Giuca 2016/02/04 05:10:31 This has almost the same thing four times. I think
Matthew Alger 2016/02/04 05:44:01 Done. We ignore bower_components because it is wh
+ if 'bower_components' in dirname:
+ continue
+
for filename in filenames:
relpath = os.path.relpath(
os.path.join(dirname, filename), TTS_REFERENCE_PATH)
expected_files.add(relpath)
for dirname, _, filenames in os.walk(self.output_dir):
+ if 'bower_components' in dirname:
+ continue
+
for filename in filenames:
relpath = os.path.relpath(
os.path.join(dirname, filename), self.output_dir)
@@ -94,12 +100,18 @@ class TestEndToEndConvert(caterpillar_test.TestCaseWithTempDir):
expected_files = set()
for dirname, _, filenames in os.walk(self.output_dir):
+ if 'bower_components' in dirname:
+ continue
+
for filename in filenames:
relpath = os.path.relpath(
os.path.join(dirname, filename), self.output_dir)
expected_files.add(relpath)
for dirname, _, filenames in os.walk(TTS_REFERENCE_PATH):
+ if 'bower_components' in dirname:
+ continue
+
for filename in filenames:
relpath = os.path.relpath(
os.path.join(dirname, filename), TTS_REFERENCE_PATH)
« no previous file with comments | « src/caterpillar.py ('k') | src/report/report.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698