drive: Remove FileCacheObserver::OnCacheCommitted

chrome/browser/chromeos/drive/file_system.h

Index: chrome/browser/chromeos/drive/file_system.h
diff --git a/chrome/browser/chromeos/drive/file_system.h b/chrome/browser/chromeos/drive/file_system.h
index d980ee318c1829321c0a869ccf56856dbd4e7afd..c976c1f68a4569a27646d897f7d8bdb0647c9b58 100644
--- a/chrome/browser/chromeos/drive/file_system.h
+++ b/chrome/browser/chromeos/drive/file_system.h
@@ -163,6 +163,8 @@ class FileSystem : public FileSystemInterface,
   // file_system::OperationObserver overrides.
   virtual void OnDirectoryChangedByOperation(
       const base::FilePath& directory_path) OVERRIDE;
+  virtual void OnCacheFileUploadNeededByOperation(
+      const std::string& resource_id) OVERRIDE;
 
   // ChangeListLoader::Observer overrides.
   // Used to propagate events from ChangeListLoader.
@@ -177,7 +179,7 @@ class FileSystem : public FileSystemInterface,
   }
 
  private:
-  friend class DriveFileSystemTest;
+  friend class FileSystemTest;

[kinaba, 2013/06/11 07:08:37]

Good catch. Do we need this friend declaration at all,
if it compiles with the wrong name?

Ah, got it. It's for accessing |sync_client_|.
Rather than making it a friend, I think adding a public method
sync_client_for_testing() looks cleaner. (change_list_loader() actually
falls into the same category.) WDYT?

[hashimoto, 2013/06/11 07:37:57]

Sounds good, done.
Maybe we should make a patch to rename change_list_loader() to
change_list_loader_for_testing() too.

 
   // Used to implement Reload().
   void ReloadAfterReset(FileError error);
@@ -239,9 +241,6 @@ class FileSystem : public FileSystemInterface,
                                       const FileOperationCallback& callback,
                                       FileError error,
                                       scoped_ptr<ResourceEntry> entry);
-  void CloseFileFinalize(const base::FilePath& file_path,
-                         const FileOperationCallback& callback,
-                         FileError result);
 
   // Callback for handling about resource fetch.
   void OnGetAboutResource(