chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: dcheck Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

index f64655ba7ed91aca3cbbb04030ab5c21862ef3c5..96da32b8c20c807667410e18ae62b6b6f3d0078d 100644

--- a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

@@ -39,8 +39,7 @@ void BookmarkBubbleSignInDelegate::EnsureBrowser() {

Profile* original_profile = profile_->GetOriginalProfile();

browser_ = chrome::FindLastActiveWithProfile(original_profile);

if (!browser_) {

- browser_ = new Browser(Browser::CreateParams(original_profile,

- desktop_type_));

sky 2016/02/08 17:28:05 Can you remove the desktop_type_ member?

scottmg 2016/02/09 18:13:14 Done.

+ browser_ = new Browser(Browser::CreateParams(original_profile));

}

« no previous file with comments | « chrome/browser/ui/ash/window_positioner_unittest.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »