Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1662763003: Revert of bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (patchset #1 id:1 of https://codereview.chromium.org/1660943002/ ) Reason for revert: I believe this breaks trybot patching on Windows. Example: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/6811 Error: 'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as an internal or external command, operable program or batch file. I'm speculatively reverting. Original issue's description: > bot_update: add depot_tools to PATH so that e.g. apply_issue can be found > > BUG=437264 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556 TBR=jochen@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +0 lines, -4 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +0 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kjellander_chromium
Created Revert of bot_update: add depot_tools to PATH so that e.g. apply_issue can be found
4 years, 10 months ago (2016-02-03 15:33:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662763003/1
4 years, 10 months ago (2016-02-03 15:33:55 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 15:34:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298561

Powered by Google App Engine
This is Rietveld 408576698