Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: net/url_request/url_request_file_job.cc

Issue 1662763002: [ON HOLD] Implement pull-based design for content decoding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_file_job.cc
diff --git a/net/url_request/url_request_file_job.cc b/net/url_request/url_request_file_job.cc
index fb224764895ea0f77d24bb488d4b4a85ad92531b..6865313d51ba434761bf7037d3d885c18ada9785 100644
--- a/net/url_request/url_request_file_job.cc
+++ b/net/url_request/url_request_file_job.cc
@@ -33,7 +33,8 @@
#include "net/base/io_buffer.h"
#include "net/base/load_flags.h"
#include "net/base/mime_util.h"
-#include "net/filter/filter.h"
+#include "net/filter/gzip_stream_source.h"
+#include "net/filter/stream_source.h"
#include "net/http/http_util.h"
#include "net/url_request/url_request_error_job.h"
#include "net/url_request/url_request_file_dir_job.h"
@@ -145,13 +146,6 @@ bool URLRequestFileJob::IsRedirectResponse(GURL* location,
#endif
}
-std::unique_ptr<Filter> URLRequestFileJob::SetupFilter() const {
- // Bug 9936 - .svgz files needs to be decompressed.
- return base::LowerCaseEqualsASCII(file_path_.Extension(), ".svgz")
- ? Filter::GZipFactory()
- : nullptr;
-}
-
bool URLRequestFileJob::GetMimeType(std::string* mime_type) const {
DCHECK(request_);
if (meta_info_.mime_type_result) {
@@ -192,6 +186,15 @@ void URLRequestFileJob::OnReadComplete(IOBuffer* buf, int result) {
URLRequestFileJob::~URLRequestFileJob() {
}
+std::unique_ptr<StreamSource> URLRequestFileJob::SetupSource() {
+ std::unique_ptr<StreamSource> source = URLRequestJob::SetupSource();
+ if (!base::LowerCaseEqualsASCII(file_path_.Extension(), ".svgz"))
+ return source;
+
+ return GzipStreamSource::Create(std::move(source),
+ GzipStreamSource::GZIP_STREAM_SOURCE_GZIP);
+}
+
void URLRequestFileJob::FetchMetaInfo(const base::FilePath& file_path,
FileMetaInfo* meta_info) {
base::File::Info file_info;

Powered by Google App Engine
This is Rietveld 408576698