net/filter/brotli_stream_source.h - Issue 1662763002: [ON HOLD] Implement pull-based design for content decoding

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/filter/brotli_stream_source.h

Issue 1662763002: [ON HOLD] Implement pull-based design for content decoding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile on mac Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_FILTER_BROTLI_STREAM_SOURCE_H__

	6 #define NET_FILTER_BROTLI_STREAM_SOURCE_H__
	mmenke 2016/07/21 18:14:08 Style is just to use one underscore in header guar Style is just to use one underscore in header guards, isn't it? xunjieli 2016/07/27 20:32:01 Done. Thanks for catching it. Probably a remnant o Show quoted text On 2016/07/21 18:14:08, mmenke wrote: > Style is just to use one underscore in header guards, isn't it? Done. Thanks for catching it. Probably a remnant of incorrect find-and-replace.
	7

	8 #include <memory>

	9

	10 #include "base/macros.h"
	mmenke 2016/07/21 18:14:08 Not used here. Move to the cc file? Not used here. Move to the cc file? xunjieli 2016/07/27 20:32:01 Done. Show quoted text On 2016/07/21 18:14:08, mmenke wrote: > Not used here. Move to the cc file? Done.
	11 #include "net/base/net_export.h"

	12 #include "net/filter/filter_stream_source.h"

	13 #include "net/filter/stream_source.h"

	14 #include "third_party/brotli/dec/decode.h"
	mmenke 2016/07/21 18:14:08 Not used here, move to the cc file? Not used here, move to the cc file? xunjieli 2016/07/27 20:32:01 Done. Show quoted text On 2016/07/21 18:14:08, mmenke wrote: > Not used here, move to the cc file? Done.
	15

	16 namespace net {

	17

	18 NET_EXPORT_PRIVATE std::unique_ptr<FilterStreamSource> CreateBrotliStreamSource(

	19 std::unique_ptr<StreamSource> previous);

	20

	21 } // namespace net

	22

	23 #endif // NET_FILTER_BROTLI_STREAM_SOURCE_H__

OLD	NEW

« no previous file with comments | « net/filter/brotli_filter_unittest.cc ('k') | net/filter/brotli_stream_source.cc » ('j') | net/filter/brotli_stream_source.cc » ('J')