Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 166273020: MIPS: Fix clz implementation of the simulator. (Closed)

Created:
6 years, 10 months ago by kilvadyb
Modified:
6 years, 10 months ago
Reviewers:
kisg, Paul Lind, palfia, danno, dusmil
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Fix clz implementation of the simulator. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/mips/simulator-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kilvadyb
6 years, 10 months ago (2014-02-20 11:56:35 UTC) #1
kilvadyb
On 2014/02/20 11:56:35, kilvadyb wrote: Please check if using CompilerIntrinsics::CountLeadingZeros() instead of __builtin_clz() is a ...
6 years, 10 months ago (2014-02-20 12:08:13 UTC) #2
Paul Lind
> Please check if using CompilerIntrinsics::CountLeadingZeros() instead of > __builtin_clz() is a good idea. I ...
6 years, 10 months ago (2014-02-20 17:13:44 UTC) #3
Paul Lind
6 years, 10 months ago (2014-02-20 21:06:24 UTC) #4
Committed as r19517.

Powered by Google App Engine
This is Rietveld 408576698