Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 166273013: In TestRunner::setValueForUser, the *second* argument needs to be a string (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

In TestRunner::setValueForUser, the *second* argument needs to be a string BUG=none R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/renderer/test_runner/TestRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-19 13:57:58 UTC) #1
Mike West
LGTM, I guess?
6 years, 10 months ago (2014-02-19 13:58:38 UTC) #2
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-19 14:00:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r252019 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698