Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 166273011: Remove --enablde-drive-v2-api flag. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Remove --enablde-drive-v2-api flag. This is a part of the flag clean up effort. The flags is enabled by default for a while and working pretty well. We won't go back any more. BUG=344738 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252060

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -67 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/drive/drive_api_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/drive/drive_api_util.cc View 3 chunks +0 lines, -17 lines 0 comments Download
D chrome/browser/drive/drive_switches.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/drive/drive_switches.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kinaba
PTAL. This patch depends on https://codereview.chromium.org/171843003/.
6 years, 10 months ago (2014-02-19 03:57:59 UTC) #1
hashimoto
lgtm
6 years, 10 months ago (2014-02-19 04:29:42 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 08:36:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/166273011/40001
6 years, 10 months ago (2014-02-19 08:37:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 09:12:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 09:12:58 UTC) #6
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 12:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/166273011/40001
6 years, 10 months ago (2014-02-19 12:47:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/166273011/40001
6 years, 10 months ago (2014-02-19 14:59:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/166273011/40001
6 years, 10 months ago (2014-02-19 15:29:06 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 20:21:53 UTC) #11
Message was sent while issue was closed.
Change committed as 252060

Powered by Google App Engine
This is Rietveld 408576698