Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166273002: Add SharedWorkerMessageFilter for the embedded SharedWorker. (Closed)

Created:
6 years, 10 months ago by horo
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add SharedWorkerMessageFilter for the embedded SharedWorker. It will be used instead of WorkerMessageFilter when "enable-embedded-shared-worker" is set. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251334

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated kinuko's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -45 lines) Patch
A + content/browser/shared_worker/shared_worker_message_filter.h View 2 chunks +35 lines, -17 lines 0 comments Download
A + content/browser/shared_worker/shared_worker_message_filter.cc View 1 2 chunks +102 lines, -22 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 2 chunks +52 lines, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 3 chunks +99 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
horo
kinuko@ Could you please review?
6 years, 10 months ago (2014-02-14 08:13:48 UTC) #1
kinuko
lgtm https://codereview.chromium.org/166273002/diff/1/content/browser/shared_worker/shared_worker_message_filter.cc File content/browser/shared_worker/shared_worker_message_filter.cc (left): https://codereview.chromium.org/166273002/diff/1/content/browser/shared_worker/shared_worker_message_filter.cc#oldcode41 content/browser/shared_worker/shared_worker_message_filter.cc:41: // Only sent from renderer for now, until ...
6 years, 10 months ago (2014-02-14 08:26:32 UTC) #2
horo
https://codereview.chromium.org/166273002/diff/1/content/browser/shared_worker/shared_worker_message_filter.cc File content/browser/shared_worker/shared_worker_message_filter.cc (left): https://codereview.chromium.org/166273002/diff/1/content/browser/shared_worker/shared_worker_message_filter.cc#oldcode41 content/browser/shared_worker/shared_worker_message_filter.cc:41: // Only sent from renderer for now, until we ...
6 years, 10 months ago (2014-02-14 08:46:25 UTC) #3
horo
jochen@ Please review this cl.
6 years, 10 months ago (2014-02-14 08:46:44 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-14 09:37:51 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 10 months ago (2014-02-14 10:49:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/166273002/110001
6 years, 10 months ago (2014-02-14 10:49:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 11:06:28 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264224
6 years, 10 months ago (2014-02-14 11:06:29 UTC) #9
horo
The CQ bit was checked by horo@chromium.org
6 years, 10 months ago (2014-02-14 12:45:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/166273002/110001
6 years, 10 months ago (2014-02-14 12:46:37 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:29:32 UTC) #12
Message was sent while issue was closed. 
Change committed as 251334

Powered by Google App Engine
This is Rietveld 408576698