Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java

Issue 1662703002: [Android, UMA, MediaFling] Add UMA for how much time users spend casting media without the media el… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java
index ee4cdda79a94f2458551407e9f659e2173e2de7d..92d9440c6242711a9036b46be83615bde51d764d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java
@@ -122,6 +122,20 @@ public class RecordCastAction {
}
}
+ /**
+ * Record the ratio of the time the remote playback continued without the media element vs the
+ * total duration of remote playback (from when the element has been attached till when the
+ * playback stopped), in percents.
aberent 2016/02/04 16:44:25 As written this includes pause time. Is this what
whywhat 2016/02/05 19:29:58 Yes, my intent is the amount of time the media ele
+ *
+ * @param percentage The ratio in percents.
+ */
+ public static void recordRemotePlaybackTimeWithoutMediaElementPercentage(int percentage) {
+ if (LibraryLoader.isInitialized()) {
+ RecordHistogram.recordEnumeratedHistogram(
Mark P 2016/02/03 22:44:57 What's wrong with recordPercentageHistogram?
whywhat 2016/02/05 19:29:57 Only that it's too far from the top of of the Reco
+ "Cast.Sender.PlaybackTimeWithoutMediaElementPercentage", percentage, 101);
+ }
+ }
+
// Cast sending
private static native void nativeRecordRemotePlaybackDeviceSelected(int deviceType);
private static native void nativeRecordCastPlayRequested();

Powered by Google App Engine
This is Rietveld 408576698