Chromium Code Reviews| Index: chrome/installer/mini_installer/mini_installer.cc |
| diff --git a/chrome/installer/mini_installer/mini_installer.cc b/chrome/installer/mini_installer/mini_installer.cc |
| index f3d7260dd40a03f4d2b8777238a181921e820f4d..8b7794f5eb0febc8f0e864d5d4ac22fd79ca8676 100644 |
| --- a/chrome/installer/mini_installer/mini_installer.cc |
| +++ b/chrome/installer/mini_installer/mini_installer.cc |
| @@ -526,9 +526,11 @@ void DeleteExtractedFiles(const wchar_t* base_path, |
| bool IsAclSupportedForPath(const wchar_t* path) { |
| PathString volume; |
| DWORD flags = 0; |
| - return ::GetVolumePathName(path, volume.get(), volume.capacity()) && |
| - ::GetVolumeInformation(volume.get(), NULL, 0, NULL, NULL, &flags, |
| - NULL, 0) && (flags & FILE_PERSISTENT_ACLS); |
| + return ::GetVolumePathName(path, volume.get(), |
| + static_cast<DWORD>(volume.capacity())) && |
|
grt (UTC plus 2)
2016/02/03 14:54:11
ah, the size_t -> DWORD conversion was the problem
gab
2016/02/03 16:21:45
Right, sorry forgot to add that to description (an
|
| + ::GetVolumeInformation(volume.get(), nullptr, 0, nullptr, nullptr, |
|
grt (UTC plus 2)
2016/02/03 14:54:11
we have to stick with C++-03 for a little longer i
gab
2016/02/03 16:21:45
Done.
|
| + &flags, nullptr, 0) && |
| + (flags & FILE_PERSISTENT_ACLS); |
| } |
| // Retrieves the SID of the default owner for objects created by this user |