Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 166263002: Fix copy number counting in Files.app. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix copy number counting in Files.app. BUG=343835 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251988

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rebase + Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M chrome/browser/resources/file_manager/background/js/file_operation_manager.js View 1 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinaba
6 years, 10 months ago (2014-02-14 08:15:49 UTC) #1
hirono
Thank you for fixing it! https://codereview.chromium.org/166263002/diff/20002/chrome/browser/resources/file_manager/background/js/file_operation_manager.js File chrome/browser/resources/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/166263002/diff/20002/chrome/browser/resources/file_manager/background/js/file_operation_manager.js#newcode639 chrome/browser/resources/file_manager/background/js/file_operation_manager.js:639: // Finalize the entry's ...
6 years, 10 months ago (2014-02-14 10:56:39 UTC) #2
kinaba
https://codereview.chromium.org/166263002/diff/20002/chrome/browser/resources/file_manager/background/js/file_operation_manager.js File chrome/browser/resources/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/166263002/diff/20002/chrome/browser/resources/file_manager/background/js/file_operation_manager.js#newcode639 chrome/browser/resources/file_manager/background/js/file_operation_manager.js:639: // Finalize the entry's progress state. On 2014/02/14 10:56:39, ...
6 years, 10 months ago (2014-02-19 00:34:35 UTC) #3
hirono
On 2014/02/19 00:34:35, kinaba (ooo until Feb 18) wrote: > https://codereview.chromium.org/166263002/diff/20002/chrome/browser/resources/file_manager/background/js/file_operation_manager.js > File > chrome/browser/resources/file_manager/background/js/file_operation_manager.js ...
6 years, 10 months ago (2014-02-19 02:13:11 UTC) #4
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 02:14:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/166263002/190001
6 years, 10 months ago (2014-02-19 02:16:56 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:04:04 UTC) #7
Message was sent while issue was closed.
Change committed as 251988

Powered by Google App Engine
This is Rietveld 408576698