Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1662613002:
Add kbr as co-owner of testing/buildbot JSON files. (Closed)
|
Created:
4 years, 10 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 10 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, Paweł Hajdan Jr. Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd kbr as co-owner of testing/buildbot JSON files.
BUG=542370
Committed: https://crrev.com/8c7d5eff834f6bef219aff6eb81697f0625784cd
Cr-Commit-Position: refs/heads/master@{#373426}
Patch Set 1 #Patch Set 2 : Made myself directory co-OWNER per suggestion from dpranke. #Messages
Total messages: 17 (8 generated)
kbr@chromium.org changed reviewers: + dpranke@chromium.org
Hi Dirk, may I be a per-file OWNER of these files? Thanks.
lgtm, though I suggest you should actually be an owner for *, not just the gpu files (you're more familiar w/ the other files and more actively using them than several other of the top-level owners).
Pawel, would you support my being a co-OWNER in this directory?
On 2016/02/02 21:47:42, Dirk Pranke wrote: > lgtm, though I suggest you should actually be an owner for *, not just the gpu > files (you're more familiar w/ the other files and more actively using them than > several other of the top-level owners). Thanks for your vote of confidence. :)
The CQ bit was checked by kbr@chromium.org
The CQ bit was unchecked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662613002/1
On 2016/02/03 00:52:51, Ken Russell wrote: > On 2016/02/02 21:47:42, Dirk Pranke wrote: > > lgtm, though I suggest you should actually be an owner for *, not just the gpu > > files (you're more familiar w/ the other files and more actively using them > than > > several other of the top-level owners). > > Thanks for your vote of confidence. :) Dirk, apologies for failing to realize you were directory co-OWNER here; was confused with the chromium_tests recipe_module. Taking your advice and making myself directory co-owner.
Description was changed from ========== Add kbr as per-file owner of GPU JSON files. BUG=542370 ========== to ========== Add kbr as co-owner of testing/buildbot JSON files. BUG=542370 ==========
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1662613002/#ps20001 (title: "Made myself directory co-OWNER per suggestion from dpranke.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662613002/20001
Message was sent while issue was closed.
Description was changed from ========== Add kbr as co-owner of testing/buildbot JSON files. BUG=542370 ========== to ========== Add kbr as co-owner of testing/buildbot JSON files. BUG=542370 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add kbr as co-owner of testing/buildbot JSON files. BUG=542370 ========== to ========== Add kbr as co-owner of testing/buildbot JSON files. BUG=542370 Committed: https://crrev.com/8c7d5eff834f6bef219aff6eb81697f0625784cd Cr-Commit-Position: refs/heads/master@{#373426} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8c7d5eff834f6bef219aff6eb81697f0625784cd Cr-Commit-Position: refs/heads/master@{#373426} |
