Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1662563002: [Offline pages] Fixing restoring bookmarks filter, when offline pages disabled (Closed)

Created:
4 years, 10 months ago by fgorski
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing restoring bookmarks filter, when offline pages disabled Ensures that when enhanced bookmarks UI is restoring the past filter for content saved offline, and offline pages are disabled, it is treating the state as invalid and reverts to the all bookmarks state. BUG=581976 Review URL: https://codereview.chromium.org/1656103002 Cr-Commit-Position: refs/heads/master@{#372983} (cherry picked from commit d1b363e7940c0b5cbc5eebd333af929b0d60032a) Committed: https://chromium.googlesource.com/chromium/src/+/53b5c9193b7d5d54b8a683db1efda87c3ada7986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUIState.java View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkTest.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fgorski
4 years, 10 months ago (2016-02-02 19:14:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53b5c9193b7d5d54b8a683db1efda87c3ada7986.

Powered by Google App Engine
This is Rietveld 408576698