Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: components/prefs/BUILD.gn

Issue 1662523004: Delete base/prefs and update callers to use components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_log.cc ('k') | components/prefs/base_prefs_export.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/BUILD.gn
diff --git a/components/prefs/BUILD.gn b/components/prefs/BUILD.gn
index 0919fe331bf7bb4696338a2ad50b9bf8249dc55b..fdbb5cf5d5ea6185abe1aa7a22aabfc51072c1f0 100644
--- a/components/prefs/BUILD.gn
+++ b/components/prefs/BUILD.gn
@@ -4,30 +4,6 @@
component("prefs") {
sources = [
- # Reference the forwarding headers so "gn check" can check them properly
- # while we're transitioning from base to here.
- "//base/prefs/base_prefs_export.h",
- "//base/prefs/default_pref_store.h",
- "//base/prefs/json_pref_store.h",
- "//base/prefs/overlay_user_pref_store.h",
- "//base/prefs/persistent_pref_store.h",
- "//base/prefs/pref_change_registrar.h",
- "//base/prefs/pref_filter.h",
- "//base/prefs/pref_member.h",
- "//base/prefs/pref_notifier.h",
- "//base/prefs/pref_notifier_impl.h",
- "//base/prefs/pref_observer.h",
- "//base/prefs/pref_registry.h",
- "//base/prefs/pref_registry_simple.h",
- "//base/prefs/pref_service_factory.h",
- "//base/prefs/pref_service.h",
- "//base/prefs/pref_store.h",
- "//base/prefs/pref_value_map.h",
- "//base/prefs/pref_value_store.h",
- "//base/prefs/scoped_user_pref_update.h",
- "//base/prefs/value_map_pref_store.h",
- "//base/prefs/writeable_pref_store.h",
-
"default_pref_store.cc",
"default_pref_store.h",
"json_pref_store.cc",
@@ -70,7 +46,7 @@ component("prefs") {
]
}
- defines = [ "BASE_PREFS_IMPLEMENTATION" ]
+ defines = [ "COMPONENTS_PREFS_IMPLEMENTATION" ]
deps = [
"//base",
@@ -85,13 +61,6 @@ component("prefs") {
source_set("test_support") {
testonly = true
sources = [
- # Reference the forwarding headers so "gn check" can check them properly
- # while we're transitioning from base to here.
- "//base/prefs/mock_pref_change_callback.h",
- "//base/prefs/pref_store_observer_mock.h",
- "//base/prefs/testing_pref_service.h",
- "//base/prefs/testing_pref_store.h",
-
"mock_pref_change_callback.cc",
"mock_pref_change_callback.h",
"pref_store_observer_mock.cc",
« no previous file with comments | « components/metrics/metrics_log.cc ('k') | components/prefs/base_prefs_export.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698