chrome/browser/notifications/balloon.cc - Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon.cc

Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/balloon.cc

diff --git a/chrome/browser/notifications/balloon.cc b/chrome/browser/notifications/balloon.cc

index 2a73c058e3297073fa7bc67550ed53b35c3020ff..099721259b62b1490050fedb6ceeef853bf10f19 100644

--- a/chrome/browser/notifications/balloon.cc

+++ b/chrome/browser/notifications/balloon.cc

@@ -82,9 +82,9 @@ void Balloon::CloseByScript() {

}

std::string Balloon::GetExtensionId() {

- const ExtensionURLInfo url(notification().origin_url());

const ExtensionService* service = profile()->GetExtensionService();

const extensions::Extension* extension =

- service->extensions()->GetExtensionOrAppByURL(url);

+ service->extensions()->GetExtensionOrAppByURL(

+ notification().origin_url());

return extension ? extension->id() : std::string();

}