Remove ExtensionURLInfo, make security decisions in render process

chrome/browser/extensions/extension_function_dispatcher.cc

Index: chrome/browser/extensions/extension_function_dispatcher.cc
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc
index ed05d097e0a1c8dc33bc197eeab6148aeedf2052..2f3bc880cf8fde205f8b020893b4108e758a29d7 100644
--- a/chrome/browser/extensions/extension_function_dispatcher.cc
+++ b/chrome/browser/extensions/extension_function_dispatcher.cc
@@ -357,9 +357,7 @@ void ExtensionFunctionDispatcher::DispatchWithCallback(
   const Extension* extension = service->extensions()->GetByID(
       params.extension_id);
   if (!extension)
-    extension = service->extensions()->GetHostedAppByURL(ExtensionURLInfo(
-        WebSecurityOrigin::createFromString(params.source_origin),

[abarth-chromium, 2013/06/10 23:12:32]

Should we check source_origin here?

[jamesr, 2013/06/10 23:36:46]

Yes. In particular, if the source_origin is unique this check should fail - but
that appears to be the only use of the source_origin IPC parameter.  We could
replace it with a bool or, since all checks will fail on a call from a unique
origin, make the source_url be an empty/invalid GURL when the source origin is
unique

[jamesr, 2013/07/10 20:38:58]

Actually, this will be the string "null" if the origin is unique. This field is
populated here:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/ex...

and toString() on a unique WebSecurityOrigin is defined to return "null", so
this'll never match for a unique origin.  So this code is fine as is.

[jamesr, 2013/07/10 20:39:55]

Sorry, the source_origin will be "null", so we can just check that.

-        params.source_url));
+    extension = service->extensions()->GetHostedAppByURL(params.source_url);
 
   scoped_refptr<ExtensionFunction> function(
       CreateExtensionFunction(params, extension,