Remove ExtensionURLInfo, make security decisions in render process

chrome/renderer/extensions/app_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/app_bindings.h"
 
 #include "base/command_line.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 101 matching lines @@
     console::Error(v8::Context::GetCalling(),
                    "Could not find frame for specified object.");
     return;
   }
 
   args.GetReturnValue().Set(GetDetailsForFrameImpl(target_frame));
 }
 
 v8::Handle<v8::Value> AppBindings::GetDetailsForFrameImpl(
     WebFrame* frame) {
+  if (frame->document().securityOrigin().isUnique())
+    return v8::Null();

[not at google - send to devlin, 2013/07/15 22:09:12]

i don't think it makes sense to check isUnique here

+
   const Extension* extension =
       dispatcher_->extensions()->GetExtensionOrAppByURL(
-          ExtensionURLInfo(frame->document().securityOrigin(),
-                           frame->document().url()));
+          frame->document().url());
+
   if (!extension)
     return v8::Null();
 
   scoped_ptr<base::DictionaryValue> manifest_copy(
       extension->manifest()->value()->DeepCopy());
   manifest_copy->SetString("id", extension->id());
   scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
   return converter->ToV8Value(manifest_copy.get(),
                               frame->mainWorldScriptContext());
 }
@@ skipping 23 matching lines @@
   // To distinguish between ready_to_run and cannot_run states, we need the top
   // level frame.
   const WebFrame* parent_frame = context()->web_frame();
   while (parent_frame->parent())
     parent_frame = parent_frame->parent();
 
   const ExtensionSet* extensions = dispatcher_->extensions();
 
   // The app associated with the top level frame.
   const Extension* parent_app = extensions->GetHostedAppByURL(
-      ExtensionURLInfo(parent_frame->document().url()));
+      parent_frame->document().url());
 
   // The app associated with this frame.
-  const Extension* this_app = extensions->GetHostedAppByURL(ExtensionURLInfo(
-      context()->web_frame()->document().url()));
+  const Extension* this_app = extensions->GetHostedAppByURL(
+      context()->web_frame()->document().url());
 
   if (!this_app || !parent_app) {
     args.GetReturnValue().Set(
         v8::String::New(extension_misc::kAppStateCannotRun));
     return;
   }
 
   const char* state = NULL;
   if (dispatcher_->IsExtensionActive(parent_app->id())) {
     if (parent_app == this_app)
@@ skipping 24 matching lines @@
   v8::Context::Scope context_scope(context()->v8_context());
   v8::Handle<v8::Value> argv[] = {
     v8::String::New(state.c_str()),
     v8::Integer::New(callback_id)
   };
   context()->module_system()->CallModuleMethod(
       "app", "onInstallStateResponse", arraysize(argv), argv);
 }
 
 }  // namespace extensions