Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1662483002: Introduce RenderingTest::getLayoutObjectByElementId(). (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce RenderingTest::getLayoutObjectByElementId(). Because it's boring to type document().getElementById("foo")->layoutObject(). Committed: https://crrev.com/795172c0cf71490d8b9f9515a3c175d355b633fc Cr-Commit-Position: refs/heads/master@{#373150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -85 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp View 17 chunks +68 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaginationTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-02 17:47:44 UTC) #2
leviw_travelin_and_unemployed
lgtm Dang, there was more of that than I expected.
4 years, 10 months ago (2016-02-03 03:01:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662483002/1
4 years, 10 months ago (2016-02-03 03:03:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 03:12:48 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 03:14:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/795172c0cf71490d8b9f9515a3c175d355b633fc
Cr-Commit-Position: refs/heads/master@{#373150}

Powered by Google App Engine
This is Rietveld 408576698