Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166243002: Cleanup: Remove unneeded browser_thread.h includes in content/. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dgrogan, dmazzoni+watch_chromium.org, miu+watch_chromium.org, joi+watch-content_chromium.org, aboxhall+watch_chromium.org, alecflett, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, dtseng+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, piman+watch_chromium.org, zork+watch_chromium.org, jsbell, plundblad+watch_chromium.org, cmumford, danakj+watch_chromium.org, James Su
Visibility:
Public.

Description

Cleanup: Remove unneeded browser_thread.h includes in content/. Fix lint errors too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251505

Patch Set 1 : lint #

Total comments: 3

Patch Set 2 : fix build, address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -35 lines) Patch
M content/browser/accessibility/accessibility_ui.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 8 chunks +13 lines, -17 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/power_monitor_message_broadcaster.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/streams/stream_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/streams/stream_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/streams/stream_handle_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/streams/stream_handle_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 10 months ago (2014-02-14 19:24:01 UTC) #1
Avi (use Gerrit)
lgtm with nits https://codereview.chromium.org/166243002/diff/50001/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/166243002/diff/50001/content/browser/indexed_db/indexed_db_database.cc#newcode694 content/browser/indexed_db/indexed_db_database.cc:694: public: structs by default are public; ...
6 years, 10 months ago (2014-02-14 20:16:42 UTC) #2
Lei Zhang
https://codereview.chromium.org/166243002/diff/50001/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/166243002/diff/50001/content/browser/indexed_db/indexed_db_database.cc#newcode694 content/browser/indexed_db/indexed_db_database.cc:694: public: On 2014/02/14 20:16:42, Avi wrote: > structs by ...
6 years, 10 months ago (2014-02-14 21:11:00 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-14 21:11:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/166243002/150001
6 years, 10 months ago (2014-02-14 21:15:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 22:34:16 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264676
6 years, 10 months ago (2014-02-14 22:34:17 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-14 22:42:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/166243002/150001
6 years, 10 months ago (2014-02-14 22:45:37 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 03:57:03 UTC) #10
Message was sent while issue was closed. 
Change committed as 251505

Powered by Google App Engine
This is Rietveld 408576698