third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h - Issue 1662423002: Make CanvasRenderingContext not inherit from ActiveDOMObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h

Issue 1662423002: Make CanvasRenderingContext not inherit from ActiveDOMObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h

diff --git a/third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h b/third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h

index 967de8b2767baa7d291d1f087da699bfd7d7ddc4..ae7efb7d84348d92196ec1e6136fcd3a652241a0 100644

--- a/third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h

+++ b/third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.h

@@ -20,6 +20,7 @@ public:

virtual ~DocumentVisibilityObserver();

virtual void didChangeVisibilityState(PageVisibilityState) = 0;

+ virtual void willDetachDocument() { };

Justin Novosad 2016/02/04 21:31:38 You could make this pure virtual ("= 0;" instead o

// Classes that inherit Node and DocumentVisibilityObserver must have a

// virtual override of Node::didMoveToNewDocument that calls

« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.h » ('j') | no next file with comments »