Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1662353002:
Add SkAutoPixmapStorage::detachPixelsAsData() (Closed)
DescriptionAdd SkAutoPixmapStorage::detachPixelsAsData()
Allows passing pixels ownership to clients.
BUG=skia:4896
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662353002
Committed: https://skia.googlesource.com/skia/+/3a94c6c62c3c40866684b4c4772551fa95be097d
Patch Set 1 #Patch Set 2 : detachPixelsAsData #
Messages
Total messages: 21 (9 generated)
Description was changed from ========== Add SkAutoPixmapStorage::leakPixels() Allows passing pixel ownership to clients. BUG=skia:4896 R=reed@google.com ========== to ========== Add SkAutoPixmapStorage::leakPixels() Allows passing pixel ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add SkAutoPixmapStorage::leakPixels() Allows passing pixel ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add SkAutoPixmapStorage::leakPixels() Allows passing pixels ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
detachPixelsAsData() ? I find the "leak" part of leakPixels very jarring? Is there a precedent for that naming?
or... detachAsImage() ?
On 2016/02/04 19:45:53, reed1 wrote: > or... > > detachAsImage() ? Wait, maybe that is too much of a layering violation. SkData is nice and low-level, so returning it is perhaps better than mentioning images...?
On 2016/02/04 19:45:29, reed1 wrote: > detachPixelsAsData() ? Done. > I find the "leak" part of leakPixels very jarring? Is there a precedent for that > naming? Not in Skia apparently :) (Blink's smart pointers use this terminology) On 2016/02/04 19:46:47, reed1 wrote: > On 2016/02/04 19:45:53, reed1 wrote: > > or... > > > > detachAsImage() ? > > Wait, maybe that is too much of a layering violation. SkData is nice and > low-level, so returning it is perhaps better than mentioning images...? Yeah, that crossed my mind too - and I also thought it'd be weird to teach SkPixmap about SkImages.
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662353002/20001
Description was changed from ========== Add SkAutoPixmapStorage::leakPixels() Allows passing pixels ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add SkAutoPixmapStorage::detachPixelsAsData() Allows passing pixels ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662353002/20001
Message was sent while issue was closed.
Description was changed from ========== Add SkAutoPixmapStorage::detachPixelsAsData() Allows passing pixels ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add SkAutoPixmapStorage::detachPixelsAsData() Allows passing pixels ownership to clients. BUG=skia:4896 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3a94c6c62c3c40866684b4c4772551fa95be097d ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3a94c6c62c3c40866684b4c4772551fa95be097d |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
