Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1662343002: Speculative fix for 2D canvas crash on Mac (Closed)

Created:
4 years, 10 months ago by Justin Novosad
Modified:
4 years, 10 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for 2D canvas crash on Mac Fix based on crash log info (have not found repro steps) BUG=580949 Committed: https://crrev.com/663be1f7fadbbd62eecfa8709df952c78e1638c8 Cr-Commit-Position: refs/heads/master@{#373601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Justin Novosad
PTAL
4 years, 10 months ago (2016-02-04 19:04:17 UTC) #2
Justin Novosad
On 2016/02/04 19:04:17, Justin Novosad wrote: > PTAL It looks like on mac, the compositor ...
4 years, 10 months ago (2016-02-04 19:08:42 UTC) #3
Stephen White
LGTM Note that this patchset looks like it has a dependency on another: (Issue 1618863002 ...
4 years, 10 months ago (2016-02-04 19:13:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662343002/1
4 years, 10 months ago (2016-02-04 19:17:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 20:16:05 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 20:17:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/663be1f7fadbbd62eecfa8709df952c78e1638c8
Cr-Commit-Position: refs/heads/master@{#373601}

Powered by Google App Engine
This is Rietveld 408576698