Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1662333002: gtk3: Fix compile by readding a constant. (Closed)

Created:
4 years, 10 months ago by Elliot Glaysher
Modified:
4 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gtk3: Fix compile by readding a constant. BUG=575038 Committed: https://crrev.com/efae915ecab88915fe1073fbaee9568a8110701c Cr-Commit-Position: refs/heads/master@{#373602}

Patch Set 1 #

Patch Set 2 : Put constant in ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
4 years, 10 months ago (2016-02-04 18:43:14 UTC) #2
Evan Stade
lgtm
4 years, 10 months ago (2016-02-04 19:39:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662333002/20001
4 years, 10 months ago (2016-02-04 20:09:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 20:16:22 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 20:18:29 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/efae915ecab88915fe1073fbaee9568a8110701c
Cr-Commit-Position: refs/heads/master@{#373602}

Powered by Google App Engine
This is Rietveld 408576698