Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 166233006: Fix for CountingPolicyTest.RemoveActions (Closed)

Created:
6 years, 10 months ago by pmarch
Modified:
6 years, 10 months ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

CountingPolicyTest.RemoveActions fails on win_rel try bots. BUG=344042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251525

Patch Set 1 #

Patch Set 2 : formating #

Patch Set 3 : added fullstream_ui_policy_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 1 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 1 2 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pmarch
Adrienne I think this will fix the test on win_rel. Let's wait for try bots ...
6 years, 10 months ago (2014-02-14 23:55:54 UTC) #1
felt
ahh, clock issues. looks like a likely culprit. lgtm.
6 years, 10 months ago (2014-02-15 00:36:06 UTC) #2
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 10 months ago (2014-02-15 02:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/166233006/230001
6 years, 10 months ago (2014-02-15 02:02:55 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 04:58:43 UTC) #5
Message was sent while issue was closed.
Change committed as 251525

Powered by Google App Engine
This is Rietveld 408576698