Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 166233004: Allow ICs to be generated for own global proxy. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Allow ICs to be generated for own global proxy. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19409

Patch Set 1 : #

Patch Set 2 : Fix prototype chain check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -27 lines) Patch
M src/code-stubs.h View 1 3 chunks +19 lines, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 1 chunk +8 lines, -5 lines 0 comments Download
M src/ic.cc View 1 5 chunks +13 lines, -9 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-14 17:37:56 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-17 07:34:26 UTC) #2
dcarney
lgtm
6 years, 10 months ago (2014-02-17 13:12:17 UTC) #3
Toon Verwaest
6 years, 10 months ago (2014-02-17 13:13:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698