Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 166233002: [Promise] Add UseCounter labels. (Closed)

Created:
6 years, 10 months ago by yhirano
Modified:
6 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yhirano
The counters were added by https://src.chromium.org/viewvc/blink?revision=167206&view=revision
6 years, 10 months ago (2014-02-14 16:24:16 UTC) #1
Ilya Sherman
https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml#oldcode26027 tools/metrics/histograms/histograms.xml:26027: <int value="268" label="UnprefixedImageSmoothingEnabled"/> What happened to 269?
6 years, 10 months ago (2014-02-14 21:26:46 UTC) #2
yhirano
https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml#oldcode26027 tools/metrics/histograms/histograms.xml:26027: <int value="268" label="UnprefixedImageSmoothingEnabled"/> On 2014/02/14 21:26:46, Ilya Sherman wrote: ...
6 years, 10 months ago (2014-02-15 01:42:00 UTC) #3
Ilya Sherman
https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml#oldcode26027 tools/metrics/histograms/histograms.xml:26027: <int value="268" label="UnprefixedImageSmoothingEnabled"/> On 2014/02/15 01:42:01, yhirano wrote: > ...
6 years, 10 months ago (2014-02-18 22:50:39 UTC) #4
yhirano
https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/166233002/diff/1/tools/metrics/histograms/histograms.xml#oldcode26027 tools/metrics/histograms/histograms.xml:26027: <int value="268" label="UnprefixedImageSmoothingEnabled"/> On 2014/02/18 22:50:39, Ilya Sherman wrote: ...
6 years, 10 months ago (2014-02-19 02:20:45 UTC) #5
Ilya Sherman
LGTM
6 years, 10 months ago (2014-02-19 05:28:29 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-19 05:28:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/166233002/70001
6 years, 10 months ago (2014-02-19 05:28:48 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:29:57 UTC) #9
Message was sent while issue was closed.
Change committed as 252003

Powered by Google App Engine
This is Rietveld 408576698