Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7567)

Unified Diff: chrome/test/nacl/nacl_browsertest_util.h

Issue 1662283002: Disabling some NaCl-related tests on Linux for flakiness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable instead of enable Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/nacl_browsertest_util.h
diff --git a/chrome/test/nacl/nacl_browsertest_util.h b/chrome/test/nacl/nacl_browsertest_util.h
index 93b00ed3f3acaf77215e602f07180c8a54e68f82..5075f61eeed151810370bed00c81385a33e9e3ea 100644
--- a/chrome/test/nacl/nacl_browsertest_util.h
+++ b/chrome/test/nacl/nacl_browsertest_util.h
@@ -195,10 +195,11 @@ class NaClBrowserTestGLibcExtension : public NaClBrowserTestGLibc {
// Similar to MAYBE_NONSFI, this is available only on x86-32, x86-64 or
// ARM linux.
+// TODO(crbug.com/579804) -- tests disabled on Linux for flakiness.
#if defined(OS_LINUX) && \
(defined(ARCH_CPU_X86_FAMILY) || defined(ARCH_CPU_ARMEL)) && \
!defined(DISABLE_NACL_BROWSERTESTS)
-# define MAYBE_PNACL_NONSFI(test_case) test_case
+# define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
#else
# define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698