Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 166223004: SafeBrowsing DownloadProtectionService: only check final URL against whitelist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc
index b727cbd77bb74eae60be4a215597a026ab76285c..8a9f6e160dd55f526854d41488af21f99a76bc82 100644
--- a/chrome/browser/safe_browsing/download_protection_service.cc
+++ b/chrome/browser/safe_browsing/download_protection_service.cc
@@ -570,21 +570,10 @@ class DownloadProtectionService::CheckClientDownloadRequest
if (!database_manager_.get()) {
reason = REASON_SB_DISABLED;
} else {
- for (size_t i = 0; i < url_chain_.size(); ++i) {
- const GURL& url = url_chain_[i];
- if (url.is_valid() &&
- database_manager_->MatchDownloadWhitelistUrl(url)) {
- VLOG(2) << url << " is on the download whitelist.";
- reason = REASON_WHITELISTED_URL;
- break;
- }
- }
- if (referrer_url_.is_valid() && reason == REASON_MAX &&
- database_manager_->MatchDownloadWhitelistUrl(
- referrer_url_)) {
- VLOG(2) << "Referrer url " << referrer_url_
- << " is on the download whitelist.";
- reason = REASON_WHITELISTED_REFERRER;
+ const GURL& url = url_chain_.back();
+ if (url.is_valid() && database_manager_->MatchDownloadWhitelistUrl(url)) {
+ VLOG(2) << url << " is on the download whitelist.";
+ reason = REASON_WHITELISTED_URL;
}
if (reason != REASON_MAX || signature_info_.trusted()) {
UMA_HISTOGRAM_COUNTS("SBClientDownload.SignedOrWhitelistedDownload", 1);

Powered by Google App Engine
This is Rietveld 408576698