Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 166223002: Removes the old download feedback string from the context menu (Closed)

Created:
6 years, 10 months ago by felt
Modified:
6 years, 10 months ago
Reviewers:
asanka
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removes the old download feedback string from the context menu The reporting feature should work via the tab modal dialog / settings. Removing the old download feedback string from the context menu. BUG=312533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251848

Patch Set 1 #

Patch Set 2 : Fixed git screwup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/download/download_shelf_context_menu.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_shelf_context_menu.cc View 1 5 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
felt
Hi Asanka, Can you review this pls? Small CL. Adrienne
6 years, 10 months ago (2014-02-14 08:11:43 UTC) #1
felt
On 2014/02/14 08:11:43, felt wrote: > Hi Asanka, > > Can you review this pls? ...
6 years, 10 months ago (2014-02-18 04:58:07 UTC) #2
asanka
LGTM
6 years, 10 months ago (2014-02-18 18:31:40 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 10 months ago (2014-02-18 18:35:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/166223002/30001
6 years, 10 months ago (2014-02-18 18:36:23 UTC) #5
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 10 months ago (2014-02-18 18:36:27 UTC) #6
felt
The CQ bit was checked by felt@chromium.org
6 years, 10 months ago (2014-02-18 18:36:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/166223002/30001
6 years, 10 months ago (2014-02-18 18:37:38 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 21:42:00 UTC) #9
Message was sent while issue was closed.
Change committed as 251848

Powered by Google App Engine
This is Rietveld 408576698